wesley/swiftui-math
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix crash when sqrt has no radicand

Browse Source
This commit is contained in:
André Douzette
2023-07-06 11:33:12 +02:00
parent 695c8a6b84
commit a482791f57
2 changed files with 41 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Sources/SwiftMath/MathRender/MTMathListBuilder.swift
View File

@@ -537,6 +537,10 @@ public struct MTMathListBuilder {
} else if command == "sqrt" {
// A sqrt command with one argument
let rad = MTRadical()
guard self.hasCharacters else {
rad.radicand = self.buildInternal(true)
return rad
}
let ch = self.getNextCharacter()
if (ch == "[") {
// special handling for sqrt[degree]{radicand}

37
Tests/SwiftMathTests/MTMathListBuilderTests.swift
View File

@@ -503,6 +503,43 @@ final class MTMathListBuilderTests: XCTestCase {
XCTAssertEqual(latex, "\\sqrt[3]{2}");
}
func testSqrtWithoutRadicand() throws {
let str = "\\sqrt"
let list = try XCTUnwrap(MTMathListBuilder.build(fromString: str))
XCTAssertEqual(list.atoms.count, 1)
let rad = try XCTUnwrap(list.atoms.first as? MTRadical)
XCTAssertEqual(rad.type, .radical)
XCTAssertEqual(rad.nucleus, "")
XCTAssertEqual(rad.radicand?.atoms.isEmpty, true)
XCTAssertNil(rad.degree)
let latex = MTMathListBuilder.mathListToString(list)
XCTAssertEqual(latex, "\\sqrt{}")
}
func testSqrtWithDegreeWithoutRadicand() throws {
let str = "\\sqrt[3]"
let list = try XCTUnwrap(MTMathListBuilder.build(fromString: str))
XCTAssertEqual(list.atoms.count, 1)
let rad = try XCTUnwrap(list.atoms.first as? MTRadical)
XCTAssertEqual(rad.type, .radical)
XCTAssertEqual(rad.nucleus, "")
XCTAssertEqual(rad.radicand?.atoms.isEmpty, true)
let subList = try XCTUnwrap(rad.degree)
XCTAssertEqual(subList.atoms.count, 1)
let atom = try XCTUnwrap(subList.atoms.first)
XCTAssertEqual(atom.type, .number)
XCTAssertEqual(atom.nucleus, "3")
let latex = MTMathListBuilder.mathListToString(list)
XCTAssertEqual(latex, "\\sqrt[3]{}");
}
func testLeftRight() throws {
let data = getTestDataLeftRight()
for testCase in data {