wesley/load-secrets-action
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve wording

Browse Source
This commit is contained in:
Eddy Filip
2023-04-24 11:17:52 +02:00
parent f4a99d4598
commit f4303b27ca
1 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
README.md
View File

@@ -102,7 +102,7 @@ jobs:
with: with:
# Persist the 1Password Connect URL for next steps. You can also persist # Persist the 1Password Connect URL for next steps. You can also persist
# the Connect token using input `connect-token`, but keep in mind that # the Connect token using input `connect-token`, but keep in mind that
# every single step in the job would then be able to access the token. # this will grant all steps of the job access to the token.
connect-host: https://1password.acme.com connect-host: https://1password.acme.com
- name: Load Docker credentials - name: Load Docker credentials
@@ -146,8 +146,8 @@ jobs:
- name: Configure 1Password Connect - name: Configure 1Password Connect
uses: 1password/load-secrets-action/configure@v1 uses: 1password/load-secrets-action/configure@v1
with: with:
# Persist the 1Password Service Account token. Keep in mind that # Persist the 1Password Service Account token. This will grant
# every single step in the job will be able to access the token. # all steps of the job access to the token.
service-account-token: ${{ secrets.OP_SERVICE_ACCOUNT_TOKEN }} service-account-token: ${{ secrets.OP_SERVICE_ACCOUNT_TOKEN }}
- name: Load Docker credentials - name: Load Docker credentials
@@ -246,7 +246,7 @@ jobs:
with: with:
# Persist the 1Password Connect URL for next steps. You can also persist # Persist the 1Password Connect URL for next steps. You can also persist
# the Connect token using input `connect-token`, but keep in mind that # the Connect token using input `connect-token`, but keep in mind that
# every single step in the job would then be able to access the token. # this will grant all steps of the job access to the token.
connect-host: https://1password.acme.com connect-host: https://1password.acme.com
- name: Load Docker credentials - name: Load Docker credentials
@@ -279,7 +279,7 @@ jobs:
with: with:
# Export loaded secrets as environment variables # Export loaded secrets as environment variables
export-env: true export-env: true
# Remove local copies of the Docker credentials, which are not needed anymore # Remove local copies of the Docker credentials, which aren't needed anymore
unset-previous: true unset-previous: true
env: env:
OP_CONNECT_TOKEN: ${{ secrets.OP_CONNECT_TOKEN }} OP_CONNECT_TOKEN: ${{ secrets.OP_CONNECT_TOKEN }}
@@ -287,8 +287,8 @@ jobs:
AWS_SECRET_ACCESS_KEY: op://app-cicd/aws/secret-access-key AWS_SECRET_ACCESS_KEY: op://app-cicd/aws/secret-access-key
- name: Deploy app - name: Deploy app
# This script expects AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY to be set, which was # This script expects AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY to be set.
# done automatically by the step above # This happened using secret references in the preceding lines.
run: ./deploy.sh run: ./deploy.sh
``` ```
@@ -310,8 +310,8 @@ jobs:
- name: Configure 1Password Connect - name: Configure 1Password Connect
uses: 1password/load-secrets-action/configure@v1 uses: 1password/load-secrets-action/configure@v1
with: with:
# Persist the 1Password Service Account token. Keep in mind that # Persist the 1Password Service Account token. This will grant
# every single step in the job will be able to access the token. # all steps of the job access to the token.
service-account-token: ${{ secrets.OP_SERVICE_ACCOUNT_TOKEN }} service-account-token: ${{ secrets.OP_SERVICE_ACCOUNT_TOKEN }}
- name: Load Docker credentials - name: Load Docker credentials
@@ -343,15 +343,15 @@ jobs:
with: with:
# Export loaded secrets as environment variables # Export loaded secrets as environment variables
export-env: true export-env: true
# Remove local copies of the Docker credentials, which are not needed anymore # Remove local copies of the Docker credentials, which aren't needed anymore
unset-previous: true unset-previous: true
env: env:
AWS_ACCESS_KEY_ID: op://app-cicd/aws/access-key-id AWS_ACCESS_KEY_ID: op://app-cicd/aws/access-key-id
AWS_SECRET_ACCESS_KEY: op://app-cicd/aws/secret-access-key AWS_SECRET_ACCESS_KEY: op://app-cicd/aws/secret-access-key
- name: Deploy app - name: Deploy app
# This script expects AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY to be set, which was # This script expects AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY to be set.
# done automatically by the step above # This happened using secret references in the preceding lines.
run: ./deploy.sh run: ./deploy.sh
``` ```