Update unit test

This commit is contained in:
Jill Regan
2026-02-22 12:37:21 -05:00
parent 50fb695a57
commit 44af64418a
2 changed files with 11 additions and 10 deletions

View File

@@ -835,21 +835,21 @@ describe("findMatchingFieldAndFile", () => {
describe("findSectionIdsByQuery", () => { describe("findSectionIdsByQuery", () => {
it("throws when sections is empty", () => { it("throws when sections is empty", () => {
expect(() => findSectionIdsByQuery([], "section-1")).toThrow( expect(() => findSectionIdsByQuery([], "section-1")).toThrow(
/section section-1 could not be found/, /Item has no sections; cannot resolve section "section-1"/,
); );
}); });
it("throws when sections is null/undefined", () => { it("throws when sections is null/undefined", () => {
expect(() => expect(() =>
findSectionIdsByQuery(undefined as unknown as FullItem["sections"], "x"), findSectionIdsByQuery(undefined as unknown as FullItem["sections"], "x"),
).toThrow(/could not be found/); ).toThrow(/Item has no sections; cannot resolve section "x"/);
}); });
it("returns section id when section matches by id", () => { it("throws when section query matches no section", () => {
const sections = [{ id: "sec-1", label: "Section 1" }]; const sections = [{ id: "sec-1", label: "Other" }];
expect( expect(() =>
findSectionIdsByQuery(sections as FullItem["sections"], "sec-1"), findSectionIdsByQuery(sections as FullItem["sections"], "nonexistent"),
).toEqual(["sec-1"]); ).toThrow(/No section matching "nonexistent" found in specified item/);
}); });
it("returns section id when section matches by label", () => { it("returns section id when section matches by label", () => {
@@ -863,7 +863,7 @@ describe("findSectionIdsByQuery", () => {
const sections = [{ id: "sec-1", label: "Other" }]; const sections = [{ id: "sec-1", label: "Other" }];
expect(() => expect(() =>
findSectionIdsByQuery(sections as FullItem["sections"], "nonexistent"), findSectionIdsByQuery(sections as FullItem["sections"], "nonexistent"),
).toThrow(/could not be found/); ).toThrow(/No section matching "nonexistent" found in specified item/);
}); });
it("returns multiple ids when multiple sections match", () => { it("returns multiple ids when multiple sections match", () => {

View File

@@ -113,7 +113,6 @@ const getFileContentWithRetry = async (
itemId: string, itemId: string,
fileId: string, fileId: string,
): Promise<string> => { ): Promise<string> => {
const maxAttempts = 3; const maxAttempts = 3;
const retryDelayMs = 2000; const retryDelayMs = 2000;
for (let attempt = 1; attempt <= maxAttempts; attempt++) { for (let attempt = 1; attempt <= maxAttempts; attempt++) {
@@ -299,7 +298,9 @@ const validateSecretRefs = (envNames: string[]): void => {
// Throw an error if any secret references are invalid // Throw an error if any secret references are invalid
if (invalid.length > 0) { if (invalid.length > 0) {
const details = invalid.map(({ name, message }) => `${name}: ${message}`).join("; "); const details = invalid
.map(({ name, message }) => `${name}: ${message}`)
.join("; ");
throw new Error(`Invalid secret reference(s): ${details}`); throw new Error(`Invalid secret reference(s): ${details}`);
} }
}; };